Care and keeping of pull requests, part iii

01 Jul 2015

See first post disclaimer

Scenario: The time has come to merge pull requests. Either you are one of the owners of a central repository and are responsible for reviewing and merging pull requests, or someone has submitted a pull request to one of your personal repositories.

To start, I’m going to assume that the pull request can be merged with no conflicts (indicated on the page with the request) or very minimal conflict. For details on more complicated merges, see the next post on magic.

In what follows, the name of the repository is mario-kart.
In our local repository, we have used origin to refer to the central repository, and master is the main branch of development. The owner/maintainer (nintendo) is merging a pull request made by someone with the github username luigi, whose pull request branch is named turtle-shell.

Merging pull requests online.

Go to the pull requests page on the github page of the central repository [1]

Click on the big green button (two times: “Merge Pull Request” and “Confirm Merge”).

The end.

Merging pull requests locally.

On Github, find the pull requestor’s copy of the repository. Fetch that repository, and check out the branch that they’re comparing (as previously described ). If the requestor is Luigi and his development branch to be merged is called turtle-shell, that process would look something like:

$ git remote add luigi
$ git fetch luigi
$ git checkout -b luigis-changes luigi/turtle-shell

Now, you want to merge luigis-changes into the master branch. Make sure to checkout master first, as that is the branch you ultimately want to update.

$ git checkout master
$ git merge luigis-changes

In theory, this method can be used even if there are conflicts at this stage; whether or not you merge conflicting pull requests into master yourself (as opposed to making the original requestor modify their requests) is up to you and the group you’re working with.

The merge is now complete; you just need to push the newly merged-in changes to the central repository:

$ git push origin master

Through some magic, Github will recognize that the changes from that pull request have been merged, and the Github page with that pull request will indicate that the branch has been merged and the PR is closed.

[1] Open pull requests can be found on the right hand menu of any repository page.

how-to » git, collaboration, care and keeping of prs,

Recent Posts



Popular Tags

ACT (2) RCF (6) Software Carpentry (6) books (3) care and keeping of prs (6) collaboration (9) computing (13) culture (10) empowerment (6) family (2) gender (2) git (9) hope (2) language (3) lessons (4) math (8) mental health (2) movies (2) personal (5) problem solving (3) programming (9) science (2) self care (3) shell (2) teaching (11) true story (5) tutoring (2) work (12)